Add typescript option to generate readonly types #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure I follow; we already support read-only types via the annotation. Is the idea that this is a global override that forces all types to be readonly, regardless of annotations? |
|
As I mentioned above, the annotations only allow you to make object properties read only. They don't allow you to make eg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's common in typescript to avoid in-place mutations. This PR allows fully read-only types to be generated.
For object types, this could previously already be achieved via lots of annotations, but this is tedious and there was no way to apply the "readonly" modifier to maps and arrays.